Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undelete _currentEvents in physics packages #607

Closed
yangfengzzz opened this issue Nov 30, 2021 · 0 comments · Fixed by #720
Closed

undelete _currentEvents in physics packages #607

yangfengzzz opened this issue Nov 30, 2021 · 0 comments · Fixed by #720
Assignees
Labels
bug Something isn't working high priority High priority issue physics Engine's physical system
Milestone

Comments

@yangfengzzz
Copy link
Member

when two collider collide together, the script delete the component, info still exit in _currentEvents which will cause the undefined. To fix this problem, we should consider two things:

  1. clear relevant index in _currentEvents after destroy entity.
  2. delete all object after one frame(not in the middle of frame).
@yangfengzzz yangfengzzz added bug Something isn't working physics Engine's physical system high priority High priority issue labels Nov 30, 2021
@yangfengzzz yangfengzzz self-assigned this Nov 30, 2021
@yangfengzzz yangfengzzz added this to the 0.7 milestone Mar 1, 2022
@GuoLei1990 GuoLei1990 linked a pull request Mar 31, 2022 that will close this issue
3 tasks
@GuoLei1990 GuoLei1990 moved this to Done in Physic Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority High priority issue physics Engine's physical system
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants