Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new particle renderer #1682

Merged
merged 186 commits into from
Sep 7, 2023

Conversation

GuoLei1990
Copy link
Member

@GuoLei1990 GuoLei1990 commented Aug 3, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Example: galacean/galacean.github.io#768

Major changes:

  • Camera add camera_Forward and camera_Up build-in shader variable
  • Component cloning supports sub property recursion clone
  • The rendering unit of the unified rendering pipeline is primitive
  • Math add Rand class
  • Add ParticleRenderer
  • Support IsContentLost for Graphic Resource

@GuoLei1990 GuoLei1990 changed the title Add New particle renderer Add new particle renderer Aug 3, 2023
@GuoLei1990 GuoLei1990 added particle enhancement New feature or request labels Aug 3, 2023
@GuoLei1990 GuoLei1990 marked this pull request as draft August 4, 2023 16:55
@GuoLei1990 GuoLei1990 requested a review from JujieX August 4, 2023 16:55
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 23.47% and project coverage change: -1.34% ⚠️

Comparison is base (8e94cc3) 62.16% compared to head (9508f13) 60.83%.
Report is 1 commits behind head on dev/1.1.

❗ Current head 9508f13 differs from pull request most recent head 2a7e0cd. Consider uploading reports for the commit 2a7e0cd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.1    #1682      +/-   ##
===========================================
- Coverage    62.16%   60.83%   -1.34%     
===========================================
  Files          430      467      +37     
  Lines        22542    23316     +774     
  Branches      3202     3317     +115     
===========================================
+ Hits         14014    14184     +170     
- Misses        7299     7904     +605     
+ Partials      1229     1228       -1     
Files Changed Coverage Δ
...ore/src/animation/animationCurve/AnimationCurve.ts 58.57% <0.00%> (ø)
packages/core/src/shader/ShaderData.ts 77.77% <ø> (-1.97%) ⬇️
packages/core/src/shaderlib/ShaderLib.ts 100.00% <ø> (ø)
packages/core/src/texture/RenderTarget.ts 57.89% <0.00%> (-1.04%) ⬇️
...ages/core/src/particle/modules/shape/ShapeUtils.ts 3.70% <3.70%> (ø)
packages/core/src/particle/ParticleGenerator.ts 4.53% <4.53%> (ø)
...ore/src/particle/modules/SizeOverLifetimeModule.ts 5.40% <5.40%> (ø)
...src/particle/modules/RotationOverLifetimeModule.ts 5.88% <5.88%> (ø)
packages/core/src/particle/modules/MainModule.ts 6.17% <6.17%> (ø)
.../src/particle/modules/ParticleCompositeGradient.ts 6.89% <6.89%> (ø)
... and 58 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

this._gl = rhi.gl;
}

/**
* Draw the primitive.
*/
draw(shaderProgram: any, subMesh: SubMesh): void {
draw(shaderProgram: any, subMesh: SubPrimitive): void {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it more appropriate to change the second parameter name from subMesh to subPrimitive?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I will opt this later

@GuoLei1990 GuoLei1990 marked this pull request as ready for review September 2, 2023 16:29
* dev/1.1:
  Fix delay add scene can't fire `onEnbaleInScene` bug (galacean#1725)
  Fix multi scene script error and GC problem (galacean#1724)
  fix: glTF parser error and test case (galacean#1723)
  fix: Script onDisable error (galacean#1719)
  "v1.1.0-alpha.2"
  Add physic unit test timeout (galacean#1717)
  "v1.0.0-beta.20"
  Fix `PhysicManager`  fixedTimeStep less than 0 bug (galacean#1715)
  Fix physx unit test (galacean#1714)
  Fix a series of physical system problems (galacean#1712)
  Fix avoid destroyed material error (galacean#1705)

# Conflicts:
#	packages/core/package.json
#	packages/design/package.json
#	packages/draco/package.json
#	packages/galacean/package.json
#	packages/loader/package.json
#	packages/math/package.json
#	packages/physics-lite/package.json
#	packages/physics-physx/package.json
#	packages/rhi-webgl/package.json
@GuoLei1990 GuoLei1990 merged commit a1ce393 into galacean:dev/1.1 Sep 7, 2023
5 checks passed
@GuoLei1990 GuoLei1990 mentioned this pull request Sep 7, 2023
3 tasks
@GuoLei1990 GuoLei1990 deleted the pr/new-particle-renderer branch September 18, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request particle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants