Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support main thread ktx2 parse #1745

Merged
merged 6 commits into from
Sep 13, 2023
Merged

Conversation

gz65555
Copy link
Collaborator

@gz65555 gz65555 commented Sep 11, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 3.07% and project coverage change: -3.21% ⚠️

Comparison is base (25367c0) 65.10% compared to head (ecff9e6) 61.89%.
Report is 11 commits behind head on main.

❗ Current head ecff9e6 differs from pull request most recent head 58a198d. Consider uploading reports for the commit 58a198d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1745      +/-   ##
==========================================
- Coverage   65.10%   61.89%   -3.21%     
==========================================
  Files         470      464       -6     
  Lines       23556    20933    -2623     
  Branches     3339     3386      +47     
==========================================
- Hits        15336    12957    -2379     
+ Misses       7020     6783     -237     
+ Partials     1200     1193       -7     
Files Changed Coverage Δ
...oader/src/ktx2/transcoder/BinomialLLCTranscoder.ts 6.25% <0.00%> (-15.18%) ⬇️
...oader/src/ktx2/transcoder/BinomialLLCWorkerCode.ts 3.03% <3.70%> (+3.03%) ⬆️

... and 338 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 changed the base branch from dev/1.1 to main September 13, 2023 09:05
@@ -1,6 +1,6 @@
{
"name": "@galacean/engine-core",
"version": "1.1.0-alpha.1",
"version": "0.0.0-experimental-ktx2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge latest main and revert version

@GuoLei1990 GuoLei1990 added enhancement New feature or request resource Resource-related functions text 2D text system and removed text 2D text system labels Sep 13, 2023
@GuoLei1990 GuoLei1990 self-assigned this Sep 13, 2023
@GuoLei1990 GuoLei1990 merged commit 266ba53 into galacean:main Sep 13, 2023
4 of 5 checks passed
@GuoLei1990 GuoLei1990 changed the title Feat/main thread ktx2 Support main thread ktx2 Sep 13, 2023
@GuoLei1990 GuoLei1990 changed the title Support main thread ktx2 Support main thread ktx2 parse Sep 13, 2023
GuoLei1990 added a commit to HypnosNova/engine-1 that referenced this pull request Sep 19, 2023
* main: (23 commits)
  Support entity reference (galacean#1417)
  feat: log physics version (galacean#1769)
  Fix Script destroy bug (galacean#1770)
  Fix collider shape bug (galacean#1768)
  fix: physics unit test timeout (galacean#1766)
  Fix `viewportPointToRay` triggers precision issues when the depth value is 1 (galacean#1767)
  fix: project loader not exported (galacean#1758)
  "v1.1.0-beta.4"
  Opt SpriteBatch code (galacean#1760)
  Fix light shader data abnormal when multiple scenes are activated (galacean#1759)
  Fix BlendShape anim compatible with multiple SkinMeshRenderer in on… (galacean#1756)
  refactor: clear code and opt memory (galacean#1757)
  test: add physx unit timeout (galacean#1755)
  "v1.1.0-beta.3"
  Fix charactor controller error (galacean#1754)
  test: fix unit test timeout
  "v1.1.0-beta.2"
  Fix clone error (galacean#1753)
  Support main thread ktx2 (galacean#1745)
  "v1.1.0-beta.1"
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request resource Resource-related functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants