Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix viewportPointToRay triggers precision issues when the depth value is 1 #1767

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Fix viewportPointToRay triggers precision issues when the depth value is 1 #1767

merged 5 commits into from
Sep 18, 2023

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

@cptbtptpbcptdtptp cptbtptpbcptdtptp added the bug Something isn't working label Sep 17, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Sep 17, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp linked an issue Sep 17, 2023 that may be closed by this pull request
ViewportPointToRay returned a wrong Ray #1720
Closed
@codecov
Copy link

codecov bot commented Sep 17, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5874bfe) 64.98% compared to head (6f78299) 64.99%.
Report is 2 commits behind head on main.

❗ Current head 6f78299 differs from pull request most recent head a5a39df. Consider uploading reports for the commit a5a39df to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1767   +/-   ##
=======================================
  Coverage   64.98%   64.99%           
=======================================
  Files         470      471    +1     
  Lines       23578    23588   +10     
  Branches     3352     3352           
=======================================
+ Hits        15323    15330    +7     
- Misses       7051     7057    +6     
+ Partials     1204     1201    -3
Files Changed Coverage Δ
packages/core/src/Camera.ts 90.66% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 merged commit 0703079 into galacean:main Sep 18, 2023
5 checks passed
GuoLei1990 added a commit to HypnosNova/engine-1 that referenced this pull request Sep 19, 2023
@GuoLei1990
Merge branch 'main' into heibing/scene
85ccc77 
* main: (23 commits)
  Support entity reference (galacean#1417)
  feat: log physics version (galacean#1769)
  Fix Script destroy bug (galacean#1770)
  Fix collider shape bug (galacean#1768)
  fix: physics unit test timeout (galacean#1766)
  Fix `viewportPointToRay` triggers precision issues when the depth value is 1 (galacean#1767)
  fix: project loader not exported (galacean#1758)
  "v1.1.0-beta.4"
  Opt SpriteBatch code (galacean#1760)
  Fix light shader data abnormal when multiple scenes are activated (galacean#1759)
  Fix BlendShape anim compatible with multiple SkinMeshRenderer in on… (galacean#1756)
  refactor: clear code and opt memory (galacean#1757)
  test: add physx unit timeout (galacean#1755)
  "v1.1.0-beta.3"
  Fix charactor controller error (galacean#1754)
  test: fix unit test timeout
  "v1.1.0-beta.2"
  Fix clone error (galacean#1753)
  Support main thread ktx2 (galacean#1745)
  "v1.1.0-beta.1"
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoLei1990 GuoLei1990 GuoLei1990 approved these changes

@lixinhang lixinhang Awaiting requested review from lixinhang

Assignees

@cptbtptpbcptdtptp cptbtptpbcptdtptp

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ViewportPointToRay returned a wrong Ray
2 participants
@cptbtptpbcptdtptp @GuoLei1990