Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlendShape anim compatible with multiple SkinMeshRenderer in on… #1756

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

luzhuang
Copy link
Contributor

…e entity

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (2f8dea7) 65.02% compared to head (6fd48b9) 65.02%.
Report is 3 commits behind head on main.

❗ Current head 6fd48b9 differs from pull request most recent head 5d7ecda. Consider uploading reports for the commit 5d7ecda to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1756      +/-   ##
==========================================
- Coverage   65.02%   65.02%   -0.01%     
==========================================
  Files         470      470              
  Lines       23583    23585       +2     
  Branches     3352     3352              
==========================================
- Hits        15336    15335       -1     
- Misses       7044     7048       +4     
+ Partials     1203     1202       -1     
Files Changed Coverage Δ
...r/BlendShapeWeightsAnimationCurveOwnerAssembler.ts 45.45% <0.00%> (-17.05%) ⬇️
packages/core/src/particle/ParticleGenerator.ts 4.53% <ø> (ø)
packages/core/src/particle/modules/MainModule.ts 6.17% <0.00%> (ø)
...src/particle/modules/RotationOverLifetimeModule.ts 5.88% <0.00%> (ø)
...rc/particle/modules/TextureSheetAnimationModule.ts 17.85% <ø> (-2.84%) ⬇️
...ages/loader/src/gltf/parser/GLTFAnimationParser.ts 60.86% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 added bug Something isn't working animation Built-in animation system related functions labels Sep 15, 2023
@GuoLei1990 GuoLei1990 merged commit ad3821d into galacean:main Sep 15, 2023
4 of 5 checks passed
luzhuang added a commit to luzhuang/engine that referenced this pull request Sep 15, 2023
…alacean#1756)

* fix: blendShape anim compatible with multiple SkinMeshRenderer in one entity
GuoLei1990 pushed a commit that referenced this pull request Sep 15, 2023
…1756) (#1764)

* fix: blendShape anim compatible with multiple SkinMeshRenderer in one entity
GuoLei1990 added a commit to HypnosNova/engine-1 that referenced this pull request Sep 19, 2023
* main: (23 commits)
  Support entity reference (galacean#1417)
  feat: log physics version (galacean#1769)
  Fix Script destroy bug (galacean#1770)
  Fix collider shape bug (galacean#1768)
  fix: physics unit test timeout (galacean#1766)
  Fix `viewportPointToRay` triggers precision issues when the depth value is 1 (galacean#1767)
  fix: project loader not exported (galacean#1758)
  "v1.1.0-beta.4"
  Opt SpriteBatch code (galacean#1760)
  Fix light shader data abnormal when multiple scenes are activated (galacean#1759)
  Fix BlendShape anim compatible with multiple SkinMeshRenderer in on… (galacean#1756)
  refactor: clear code and opt memory (galacean#1757)
  test: add physx unit timeout (galacean#1755)
  "v1.1.0-beta.3"
  Fix charactor controller error (galacean#1754)
  test: fix unit test timeout
  "v1.1.0-beta.2"
  Fix clone error (galacean#1753)
  Support main thread ktx2 (galacean#1745)
  "v1.1.0-beta.1"
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
animation Built-in animation system related functions bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants