Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collider shape bug #1768

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

GuoLei1990
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 72.00% and project coverage change: +0.04% 🎉

Comparison is base (5450de4) 64.99% compared to head (60b190b) 65.04%.

❗ Current head 60b190b differs from pull request most recent head 3a7390f. Consider uploading reports for the commit 3a7390f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1768      +/-   ##
==========================================
+ Coverage   64.99%   65.04%   +0.04%     
==========================================
  Files         471      471              
  Lines       23588    23604      +16     
  Branches     3352     3355       +3     
==========================================
+ Hits        15332    15354      +22     
+ Misses       7055     7050       -5     
+ Partials     1201     1200       -1     
Files Changed Coverage Δ
packages/core/src/physics/CharacterController.ts 54.83% <40.00%> (-2.57%) ⬇️
packages/core/src/physics/Collider.ts 89.09% <92.30%> (-0.28%) ⬇️
packages/core/src/Component.ts 94.73% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@luzhuang luzhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@luzhuang luzhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@luzhuang luzhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 merged commit 840babd into galacean:main Sep 18, 2023
5 checks passed
@GuoLei1990 GuoLei1990 added the bug Something isn't working label Sep 18, 2023
@GuoLei1990 GuoLei1990 deleted the pr/fix-physic-shape-bug branch September 18, 2023 14:00
GuoLei1990 added a commit to HypnosNova/engine-1 that referenced this pull request Sep 19, 2023
* main: (23 commits)
  Support entity reference (galacean#1417)
  feat: log physics version (galacean#1769)
  Fix Script destroy bug (galacean#1770)
  Fix collider shape bug (galacean#1768)
  fix: physics unit test timeout (galacean#1766)
  Fix `viewportPointToRay` triggers precision issues when the depth value is 1 (galacean#1767)
  fix: project loader not exported (galacean#1758)
  "v1.1.0-beta.4"
  Opt SpriteBatch code (galacean#1760)
  Fix light shader data abnormal when multiple scenes are activated (galacean#1759)
  Fix BlendShape anim compatible with multiple SkinMeshRenderer in on… (galacean#1756)
  refactor: clear code and opt memory (galacean#1757)
  test: add physx unit timeout (galacean#1755)
  "v1.1.0-beta.3"
  Fix charactor controller error (galacean#1754)
  test: fix unit test timeout
  "v1.1.0-beta.2"
  Fix clone error (galacean#1753)
  Support main thread ktx2 (galacean#1745)
  "v1.1.0-beta.1"
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants