Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ktx2 offset is not correct #1820

Merged
merged 8 commits into from
Oct 17, 2023
Merged

Conversation

gz65555
Copy link
Collaborator

@gz65555 gz65555 commented Oct 16, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (014de1d) 64.28% compared to head (3a91f1c) 65.02%.
Report is 1 commits behind head on main.

❗ Current head 3a91f1c differs from pull request most recent head 4c0d198. Consider uploading reports for the commit 4c0d198 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1820      +/-   ##
==========================================
+ Coverage   64.28%   65.02%   +0.73%     
==========================================
  Files         473      473              
  Lines       23757    23750       -7     
  Branches     3369     3368       -1     
==========================================
+ Hits        15273    15444     +171     
+ Misses       7294     7107     -187     
- Partials     1190     1199       +9     
Files Coverage Δ
packages/core/src/Engine.ts 87.04% <ø> (-0.13%) ⬇️
packages/core/src/asset/ResourceManager.ts 60.09% <100.00%> (ø)
packages/loader/src/ktx2/KTX2Container.ts 6.89% <0.00%> (ø)
...resource-deserialize/resources/mesh/MeshDecoder.ts 2.19% <0.00%> (ø)
packages/loader/src/ktx2/KTX2Loader.ts 14.77% <33.33%> (+1.72%) ⬆️

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 changed the title fix: offset is not correct Fix ktx2 offset is not correct Oct 17, 2023
usage: KTX2Usage;
}

/** KTX2 Texture Usage */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KTX2 Texture Usage.

@GuoLei1990 GuoLei1990 added bug Something isn't working texture labels Oct 17, 2023
@GuoLei1990 GuoLei1990 merged commit f95cc90 into galacean:main Oct 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working texture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants