Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gltf accessor's bufferView could be undefined #2013

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Fix gltf accessor's bufferView could be undefined #2013

merged 2 commits into from
Feb 27, 2024

Conversation

gz65555
Copy link
Collaborator

@gz65555 gz65555 commented Feb 27, 2024 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

follow the instruction of standard of gltf: https://github.com/KhronosGroup/glTF/blob/main/specification/2.0/schema/accessor.schema.json#L12C13-L12C212

The bufferView field of accessor could be undefined. We should use 0 instead of undefined.

zhuxudong
zhuxudong approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@zhuxudong zhuxudong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 changed the title fix: gltf accessor's bufferView could be undefined Fix gltf accessor's bufferView could be undefined Feb 27, 2024
@GuoLei1990 GuoLei1990 merged commit 57f6c8a into galacean:main Feb 27, 2024
6 checks passed
@GuoLei1990 GuoLei1990 added the bug Something isn't working label Feb 27, 2024
GuoLei1990 added a commit that referenced this pull request Feb 29, 2024
@GuoLei1990
Merge branch 'main' into dev/1.2
5937321 
* main:
  Fix gltf accessor's bufferView could be undefined (#2013)
  Fix `IPhysicsScene.removeColliderShape` not cleaned up `eventMap` (#2008)
@GuoLei1990 GuoLei1990 mentioned this pull request Mar 13, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuxudong zhuxudong zhuxudong approved these changes

@GuoLei1990 GuoLei1990 GuoLei1990 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working glTF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gz65555 @GuoLei1990 @zhuxudong