Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skinned mesh renderer has incorrect bounding box when there is n… #2015

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

@cptbtptpbcptdtptp cptbtptpbcptdtptp commented Feb 28, 2024

…o root bone

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Feb 28, 2024
@GuoLei1990 GuoLei1990 added bug Something isn't working mesh labels Mar 4, 2024
@GuoLei1990 GuoLei1990 merged commit a6c365e into galacean:main Mar 4, 2024
6 checks passed
GuoLei1990 added a commit that referenced this pull request Mar 8, 2024
* main:
  Fix `pass.renderstate` does not work in `SpriteRenderer` (#2023)
  fix: skinned mesh renderer destroy bug (#2020)
  "v1.1.0-beta.50"
  Fix skinned mesh renderer has incorrect bounding box when there is n… (#2015)

# Conflicts:
#	packages/core/package.json
#	packages/core/src/Renderer.ts
#	packages/core/src/mesh/SkinnedMeshRenderer.ts
#	packages/design/package.json
#	packages/draco/package.json
#	packages/galacean/package.json
#	packages/loader/package.json
#	packages/math/package.json
#	packages/physics-lite/package.json
#	packages/physics-physx/package.json
#	packages/rhi-webgl/package.json
#	packages/shader-lab/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mesh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants