Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summation over HII region n_H densities #627

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

sachiwee
Copy link
Contributor

Update the calculation of emission line luminosities in HII regions to sum over a distribution of hydrogen densities.

@github-actions github-actions bot requested a review from abensonca June 12, 2024 21:55
@abensonca abensonca added the emission lines Issues related to emission lines label Jun 13, 2024
Cleans up variable names, fixes fomatting, adds a suitable reference for default parameter values, and renames a file for consistency.
Also cleans up formatting.
Copy link
Collaborator

@abensonca abensonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good now - will commit after tests pass.

@abensonca abensonca added this pull request to the merge queue Jun 14, 2024
Merged via the queue into galacticusorg:master with commit f5121c7 Jun 14, 2024
274 of 277 checks passed
@abensonca abensonca deleted the Galacticus_nHrange branch June 14, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emission lines Issues related to emission lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants