Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

improvements to build-locally script #190

Merged
merged 2 commits into from
Nov 4, 2022
Merged

improvements to build-locally script #190

merged 2 commits into from
Nov 4, 2022

Conversation

techcobweb
Copy link
Contributor

Signed-off-by: Mike Cobbett 77053+techcobweb@users.noreply.github.com

@techcobweb
improvements to build-locally script
8f094bd 
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@techcobweb
clean option wasn't working as expected
78d19d8 
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@techcobweb techcobweb requested a review from jadecarino November 4, 2022 11:37
jadecarino
jadecarino approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good - the test failure does need addressing at some point, but not to do with this script so happy for you to merge in.

@techcobweb techcobweb merged commit c6aa211 into main Nov 4, 2022
@techcobweb techcobweb deleted the build-locally branch June 6, 2023 08:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jadecarino jadecarino jadecarino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@techcobweb @jadecarino