Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

techcobweb-1266-local-build-obr-change #194

Merged
merged 6 commits into from
Nov 22, 2022

Conversation

techcobweb
Copy link
Contributor

@techcobweb techcobweb commented Nov 21, 2022

Signed-off-by: Mike Cobbett 77053+techcobweb@users.noreply.github.com

  • Local builds pick up OBR from different location
  • Ignore failing junit tests until we make them work with issue #1250
  • minor javadoc corrections

Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@galasa-team
Copy link

Build successful

Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@galasa-team
Copy link

Build successful

Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@galasa-team
Copy link

Build successful

Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@galasa-team
Copy link

Build successful

1 similar comment
@galasa-team
Copy link

Build successful

@techcobweb
Copy link
Contributor Author

techcobweb commented Nov 22, 2022

Comments from Caroline:
Hi, for 194, I spotted a couple of tiny typos

  • there is still a registrtion lurking and also
  • you have "A map of key, value pairs" which I think should be "A map of key-value pairs".
  • I assume that the inheritDoc annotation is a simplification of what is there.
  • I am just checking my notes regarding the change to the license wording but assuming it is what Gary Bettesworth said it should be.

Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@techcobweb
Copy link
Contributor Author

Changes for spelling and key-value pair pushed.

@techcobweb
Copy link
Contributor Author

The inheritdoc is far less likely to create a broken link. In fact, even that isn't required, as inheriting the doc is done by default anyway, but it does make it explicit, and deleting the entire javadoc seemed to brutal a change for now.

@galasa-team
Copy link

Build successful

@techcobweb techcobweb merged commit 256f6c9 into main Nov 22, 2022
@techcobweb techcobweb deleted the techcobweb-1266-local-build-obr-change branch November 22, 2022 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants