Fix use of GalaxyClient with username/password on py3 #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsoranzo
reviewed
Sep 14, 2017
bioblend/galaxyclient.py
Outdated
| @@ -201,7 +201,7 @@ def make_put_request(self, url, payload=None, params=None): | |||
| @property | |||
| def key(self): | |||
| if not self._key and self.email is not None and self.password is not None: | |||
| unencoded_credentials = "%s:%s" % (self.email, self.password) | |||
| unencoded_credentials = b"%s:%s" % (self.email, self.password) | |||
There was a problem hiding this comment.
This raises an exception for me:
TypeError: unsupported operand type(s) for %: 'bytes' and 'tuple'
what about modifying the next line instead to:
authorization = base64.b64encode(unencoded_credentials.encode())There was a problem hiding this comment.
I could have sworn I tested this under py3 as well :).
mvdbeek
force-pushed
the
encode_fix_py3
branch
from
eb74ae9
to
e0b5ed2
Compare
|
I've rebased the commit with the right fix. |
nsoranzo
approved these changes
Sep 14, 2017
|
Thanks @mvdbeek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.