Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong insert position for auto-generated code when using macros #82

Closed
davelopez opened this issue Jan 2, 2021 · 0 comments · Fixed by #83
Closed

Wrong insert position for auto-generated code when using macros #82

davelopez opened this issue Jan 2, 2021 · 0 comments · Fixed by #83
Assignees
Labels
bug Something isn't working language server Related to the language server
Milestone

Comments

@davelopez
Copy link
Collaborator

davelopez commented Jan 2, 2021

Currently, the expanded (all macros expanded) version of the document is used to determine the <inputs> and <outputs> of the tool when trying to auto-generate the tests (#73) or command (#77) sections.
While this is important to retrieve the real inputs and outputs of the tool, the exact insert position for the auto-generated code is also based on the expanded version, leading to a resulting insert position that does not match the 'unexpanded' document version.

We should keep both 'expanded' and 'unexpanded' versions of the document and use the 'unexpanded' one to calculate the insert position.

@davelopez davelopez added bug Something isn't working language server Related to the language server labels Jan 2, 2021
@davelopez davelopez added this to the v0.3.1 milestone Jan 2, 2021
@davelopez davelopez self-assigned this Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working language server Related to the language server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant