Generate command section #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davelopez
added
feature
bgruening
reviewed
Dec 23, 2020
bgruening
reviewed
Dec 23, 2020
bgruening
reviewed
Dec 23, 2020
| ${8:TODO_argument} '\$c1.c2.c2_a2_p1' | ||
| #for \$${9:i}, \$${10:var} in enumerate(\$c1.c2.rep): | ||
| ${11:TODO_argument} '\$${10:var}.rep_p1' | ||
| #for \$${12:i}, \$${13:var} in enumerate(\$${10:var}.sub_rep): |
There was a problem hiding this comment.
i probaby does not need to be marker and if we name the other variable item we can just hardocde it and also remove the marker. What do you think?
There was a problem hiding this comment.
Sure! I will remove the placeholder in the $i. On the other hand, I think it is a better idea to keep the placeholder in the $var since it can collide with nested repeats and allows to rename all the related $var variables at the same time. Like this:
bgruening
approved these changes
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new custom command for the language server that tries to generate some boilerplate/scaffold Cheetah code for the command section of the current tool. The information is based on the current
inputsandoutputsdefined when the command is executed.The command can be executed in the VSCode client using the shortcut
Ctrl+Alt+c(Cmd+Alt+cin Mac).For testing the generated Cheetah snippets a new test case has been added with the corresponding expected XML files.
The process for inserting snippets in the
clienthas been improved to support insertion with replacing range, this allows replacing a possible auto-closed<command/>tag with the generated snippet instead of inserting the snippet alongside the existing<command/>. This enhancement has been also added for #73.During the addition of tests for this enhancement, a miscalculation in the offsets of the tokens in XML parsing has been discovered and hopefully fixed :)
This PR closes #76