Merge pull request #7201 from mvdbeek/fix_view_metadata_error

[18.09] Fix error in view_tool_metadata
galaxyproject · Jan 11, 2019 · 105a1d8 · 105a1d8
2 parents a7ae521 + 141c2a1
commit 105a1d8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lib/galaxy/webapps/tool_shed/controllers/repository.py b/lib/galaxy/webapps/tool_shed/controllers/repository.py
@@ -880,8 +880,8 @@ def display_tool(self, trans, repository_id, tool_config, changeset_revision, **
         with ValidationContext.from_app(trans.app) as validation_context:
             tv = tool_validator.ToolValidator(validation_context)
             repository, tool, valid, message = tv.load_tool_from_changeset_revision(repository_id,
-                                                                             changeset_revision,
-                                                                             tool_config)
+                                                                                    changeset_revision,
+                                                                                    tool_config)
         if message or not valid:
             status = 'error'
         tool_state = tool_util.new_state(trans, tool, invalid=not valid)
@@ -1772,8 +1772,8 @@ def load_invalid_tool(self, trans, repository_id, tool_config, changeset_revisio
         with ValidationContext.from_app(trans.app) as validation_context:
             tv = tool_validator.ToolValidator(validation_context)
             repository, tool, valid, error_message = tv.load_tool_from_changeset_revision(repository_id,
-                                                                                   changeset_revision,
-                                                                                   tool_config)
+                                                                                          changeset_revision,
+                                                                                          tool_config)
             tool_state = tool_util.new_state(trans, tool, invalid=True)
             invalid_file_tups = []
             if tool:
@@ -2931,7 +2931,7 @@ def view_tool_metadata(self, trans, repository_id, changeset_revision, tool_id,
                                     if message:
                                         status = 'error'
                                 else:
-                                    tool, message, sample_files = \
+                                    tool, valid, message, sample_files = \
                                         tv.handle_sample_files_and_load_tool_from_tmp_config(repo,
                                                                                              repository_id,
                                                                                              changeset_revision,

diff --git a/lib/tool_shed/tools/tool_validator.py b/lib/tool_shed/tools/tool_validator.py
@@ -225,7 +225,7 @@ def handle_sample_files_and_load_tool_from_tmp_config(self, repo, repository_id,
                 # Load entries into the tool_data_tables if the tool requires them.
                 tool_data_table_config = os.path.join(work_dir, 'tool_data_table_conf.xml')
                 error, message = self.stdtm.handle_sample_tool_data_table_conf_file(tool_data_table_config,
-                                                                                   persist=False)
+                                                                                    persist=False)
         manifest_ctx, ctx_file = hg_util.get_ctx_file_path_from_manifest(tool_config_filename, repo, changeset_revision)
         if manifest_ctx and ctx_file:
             tool, valid, message2 = self.load_tool_from_tmp_config(repo, repository_id, manifest_ctx, ctx_file, work_dir)