Merge pull request #8585 from guerler/fix_toolshed_error_parsing

Fix parsing of errors in toolshed interface
galaxyproject · Sep 6, 2019 · b70871a · b70871a
2 parents 431c96d + b8c498e
commit b70871a
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/client/galaxy/scripts/components/Toolshed/services.js b/client/galaxy/scripts/components/Toolshed/services.js
@@ -10,7 +10,7 @@ export class Services {
             const response = await axios.get(url);
             return response.data;
         } catch (e) {
-            return this._errorMessage(e);
+            this._errorMessage(e);
         }
     }
     async getRepositories(params) {
@@ -27,7 +27,7 @@ export class Services {
             });
             return incoming;
         } catch (e) {
-            return this._errorMessage(e);
+            this._errorMessage(e);
         }
     }
     async getDetails(toolshedUrl, repository_id) {
@@ -48,7 +48,7 @@ export class Services {
             });
             return table;
         } catch (e) {
-            return `${this._errorMessage(e)}, ${url}`;
+            this._errorMessage(e);
         }
     }
     async getInstalledRepositories(repo) {
@@ -76,7 +76,7 @@ export class Services {
             const response = await axios.post(url, payload);
             return response.data;
         } catch (e) {
-            return this._errorMessage(e);
+            this._errorMessage(e);
         }
     }
     async uninstallRepository(params) {
@@ -88,7 +88,7 @@ export class Services {
             const response = await axios.delete(url);
             return response.data;
         } catch (e) {
-            return this._errorMessage(e);
+            this._errorMessage(e);
         }
     }
     _formatCount(value) {
@@ -100,7 +100,7 @@ export class Services {
         if (e.response) {
             message = e.response.data.err_msg || `${e.response.statusText} (${e.response.status})`;
         }
-        return message;
+        throw message;
     }
     _getParamString(params) {
         return Object.keys(params).reduce(function(previous, key) {