-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some issues with Virtual Scroller #12458
Comments
I've observed most of the issues listed here on a smaller sample size (n=100) in Chrome. |
I created a little powerpoint with some of my findings and my suggestions for moving forward: https://docs.google.com/presentation/d/1UTDKzRi-McxkHExQ9EBBobczIVg5gUcC0KbHbuH4mVw/edit?usp=sharing |
Thanks @assuntad23. Would an infinite scroller work, when we add a "jumping" interface to it? Let's say you have 1000 datasets, type in 100 and jump to 100? Would in this case the entire history be loaded, or can we jump to 100 and scroll until 1 without having 1000-900 in the cache? |
@bgruening I'm not sure, but I'm leaning towards no. There is potential for it to work, but I wonder if it would mess up the order of the whole history to do so. Also, I've never seen anything like that "in the wild". I think it could is definitely possible with a FOSS Virtual Scroller, but the requirements for those seem to be incompatible with the ContentProvider, afaik, because they expect the whole list of objects upfront. |
Closing this as resolved since we've ditched that virtual scroller. Thanks for all the diagnosis and work here @assuntad23. |
Describe the bug
This is a list of the issues I found when playing with the Virtual Scroller. I created a history with a dataset of 1008 items to test this with.
Galaxy Version and/or server at which you observed the bug
Galaxy Version: 21.09/dev
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The scrolling should behave more consistently and should be easier to navigate through the history. Ease of use for new users is important too.
Screenshots
Here's a video of me playing around with it a bit. It shows some of the odd behaviors.
https://user-images.githubusercontent.com/26912553/133289648-b827244f-478d-424f-940b-1e1a70203384.mp4
** Vue Virtual Scroller Swap **
simplescreenrecorder-2021-09-20_21.17.16.mp4
The text was updated successfully, but these errors were encountered: