Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues with Virtual Scroller #12458

Closed
assuntad23 opened this issue Sep 14, 2021 · 5 comments
Closed

Some issues with Virtual Scroller #12458

assuntad23 opened this issue Sep 14, 2021 · 5 comments

Comments

@assuntad23
Copy link
Contributor

assuntad23 commented Sep 14, 2021

Describe the bug
This is a list of the issues I found when playing with the Virtual Scroller. I created a history with a dataset of 1008 items to test this with.

Galaxy Version and/or server at which you observed the bug
Galaxy Version: 21.09/dev

  1. Double scroll bar makes scrolling confusing.
  • It's hard to tell where you are in the history
  • Larger bar jumps around and changes size a bit.
  • What is the purpose of the large bar?
  • Should they be next to eachother instead of on top of eachother?
  1. When scrolling though history with mouse scroller
  • Smoothly scrolls for about three long "pulls", then stops and jumps to a seemingly random place in the history (at one point it was 500 datasets lower, at another time it was 800 datasets away)
  • After about 300 datasets pass by or so, the history pauses on loading content and you are scrolling through a grey box until it catches up.
  1. Top & Bottom of list Oddities
  • When at the top, if waiting for a job to run, you must scroll up to see it. The history does not expand to cover the new job in the queue
  • When all the way at the bottom, it is possible to show just one dataset, and a whole grey box, even if you have a bunch of datasets. This seems weird.

To Reproduce
Steps to reproduce the behavior:

  1. Create a longer history
  2. Using the new history, try to scroll up and down fast
  3. Try to find a specific place in the history, like a midway point
  4. Scroll all the way to the bottom
  5. Scroll all the way to the top
  6. Add a job to the queue

Expected behavior
The scrolling should behave more consistently and should be easier to navigate through the history. Ease of use for new users is important too.

Screenshots
Here's a video of me playing around with it a bit. It shows some of the odd behaviors.
https://user-images.githubusercontent.com/26912553/133289648-b827244f-478d-424f-940b-1e1a70203384.mp4

** Vue Virtual Scroller Swap **

simplescreenrecorder-2021-09-20_21.17.16.mp4
@jdavcs
Copy link
Member

jdavcs commented Sep 17, 2021

I've observed most of the issues listed here on a smaller sample size (n=100) in Chrome.

@assuntad23
Copy link
Contributor Author

assuntad23 commented Oct 15, 2021

I created a little powerpoint with some of my findings and my suggestions for moving forward:

https://docs.google.com/presentation/d/1UTDKzRi-McxkHExQ9EBBobczIVg5gUcC0KbHbuH4mVw/edit?usp=sharing

@bgruening
Copy link
Member

bgruening commented Oct 15, 2021

Thanks @assuntad23.

Would an infinite scroller work, when we add a "jumping" interface to it? Let's say you have 1000 datasets, type in 100 and jump to 100? Would in this case the entire history be loaded, or can we jump to 100 and scroll until 1 without having 1000-900 in the cache?

@assuntad23
Copy link
Contributor Author

@bgruening I'm not sure, but I'm leaning towards no. There is potential for it to work, but I wonder if it would mess up the order of the whole history to do so. Also, I've never seen anything like that "in the wild".

I think it could is definitely possible with a FOSS Virtual Scroller, but the requirements for those seem to be incompatible with the ContentProvider, afaik, because they expect the whole list of objects upfront.

@dannon
Copy link
Member

dannon commented Feb 16, 2022

Closing this as resolved since we've ditched that virtual scroller. Thanks for all the diagnosis and work here @assuntad23.

@dannon dannon closed this as completed Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

4 participants