Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subworkflows still listed in Invocations List? #17760

Closed
ahmedhamidawan opened this issue Mar 15, 2024 · 1 comment
Closed

Subworkflows still listed in Invocations List? #17760

ahmedhamidawan opened this issue Mar 15, 2024 · 1 comment
Assignees
@mvdbeek
Labels
area/UI-UX area/workflows kind/bug release-testing-24.0
Milestone
24.0

Comments

@ahmedhamidawan
Copy link
Member

ahmedhamidawan commented Mar 15, 2024 •
edited

Describe the bug
I would now not expect InvocationsList to show subworkflow invocations because of the change in Filter out subworkflow invocations 17558
To Reproduce
Steps to reproduce the behavior:

  1. Run a workflow with subworkflows
  2. Go to Invocations List
  3. Subworkflow-runs will be listed along with the parent workflow invocation

Expected behavior
Only the parent workflow invocation should be listed

Screenshots

subworkflows_still_in_list.mp4
@jdavcs jdavcs added this to the 24.0 milestone Mar 15, 2024
@mvdbeek mvdbeek self-assigned this Mar 18, 2024
mvdbeek added a commit to mvdbeek/galaxy that referenced this issue Mar 18, 2024
@mvdbeek
Fix include_nested_invocations passing, drop unused provder method
50b9c5c 
Fixes galaxyproject#17760
@mvdbeek mvdbeek mentioned this issue Mar 18, 2024
Merged
4 tasks
mvdbeek added a commit to mvdbeek/galaxy that referenced this issue Mar 18, 2024
@mvdbeek
Fix include_nested_invocations passing, drop unused provder method
f776c3a 
Fixes galaxyproject#17760
mvdbeek added a commit that referenced this issue Mar 18, 2024
@mvdbeek
Fix include_nested_invocations passing, drop unused provder method
51c5c38 
Fixes #17760
mvdbeek added a commit that referenced this issue Mar 18, 2024
@mvdbeek
Fix include_nested_invocations passing, drop unused provder method
485b7e9 
Fixes #17760
@jdavcs
Copy link
Member

jdavcs commented Mar 18, 2024

Fixed in #17768

@jdavcs jdavcs closed this as completed Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvdbeek mvdbeek

Labels
area/UI-UX area/workflows kind/bug release-testing-24.0
Projects
None yet
Milestone
24.0
Development

No branches or pull requests
3 participants
@jdavcs @mvdbeek @ahmedhamidawan