Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out subworkflow invocations #17558

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Feb 28, 2024

I think users don't need to see their nested invocations from the main invocation list. If needed they can be found through the invocation steps. The only exception we're making is that we show subworkflow invocations if filtering for a specific workflow id.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

I think users don't need to see their nested invocations from the main
invocation list. If needed they can be found through the invocation
steps. The only exception we're making is that we show subworkflow
invocations if filtering for a specific workflow id.
@mvdbeek mvdbeek marked this pull request as ready for review February 28, 2024 17:17
@mvdbeek mvdbeek merged commit 352ff35 into galaxyproject:dev Feb 28, 2024
55 of 56 checks passed
@github-actions github-actions bot added this to the 24.1 milestone Feb 28, 2024
@nsoranzo nsoranzo deleted the subworkflow_filtering branch February 28, 2024 17:47
@jdavcs jdavcs modified the milestones: 24.1, 24.0 Mar 1, 2024
@galaxyproject galaxyproject deleted a comment from github-actions bot Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants