Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda dependency resolver auto_installer fails if conda_prefix is too long #2537

Closed
pvanheus opened this issue Jun 25, 2016 · 10 comments
Closed

Comments

@pvanheus
Copy link
Contributor

The conda dependency resolver (unsurprisingly) is affected by this conda issue: readthedocs/readthedocs.org#1902 . In short, if the conda_prefix and resulting environment name is longer than the name of the prefix used during package build time, the installer will fail. A typical error message is:

Error: ERROR: placeholder '/root/miniconda3/envs/_build_placehold_placehold_placehold_placehold_placehold_p' too short in: ncurses-5.9-4

I doubt there is anything that can be done from the Galaxy side to fix this, but perhaps a documentation patch is in order.

@bgruening
Copy link
Member

@pvanheus I think this was fixed upstream: conda/conda-build#877
Unfortunately, we are still stuck with an older version because of this: conda/conda#2035

@nsoranzo
Copy link
Member

@bgruening The broken conda packages still need to be rebuilt, see conda/conda#2353 (comment)

@bgruening
Copy link
Member

Sure, but this is a larger effort. It only happens for users with a large prefix afaik.

@pvanheus
Copy link
Contributor Author

I've written a new test (part of #2538) that will fail when we use a conda with this issue fixed) and added a warning message if the prefix is > 50 characters. This issue should be mentioned in the conda dependency manager docs too.

@jmchilton
Copy link
Member

This seems to be fixed with recent conda upgrade and is included in 17.01. xref #3482

@bernt-matthias
Copy link
Contributor

bernt-matthias commented Apr 21, 2017

But, there is still the message if the prefix is to long and galaxy.ini also contains text on to long prefix. Should be changed if the bug is fixed (also for job_working_directory).

@jmchilton
Copy link
Member

@bernt-matthias What message are you seeing?

If it looks something like:

Error: ERROR: placeholder '/root/miniconda3/envs/_build_placehold_placehold_placehold_placehold_placehold_p' too short in: ncurses-5.9-4

You may need to ping someone on bioconda to rebuild the package - this shouldn't happen with newer packages.

@bernt-matthias
Copy link
Contributor

bernt-matthias commented May 2, 2017

Sorry, I should have been more specific. The warning message that is printed during galaxy (17.01) startup is:

galaxy.tools.deps.resolvers.conda WARNING 2017-05-02 07:13:47,479 Conda install prefix '/gpfs1/data/galaxy_server/galaxy-dev/database/dependencies/_conda' is 65 characters long, this can cause problems with package installation, consider setting a shorter prefix (conda_prefix in galaxy.ini)

galaxy.ini contains the following comment:

# IMPORTANT: Due to a current limitation in conda, the total length of the
# conda_prefix and the job_working_directory path should be less than 50 characters!

@mvdbeek
Copy link
Member

mvdbeek commented May 2, 2017

Yeah, this is a legacy warning by now. We can remove this, I think.
I think we already removed this in dev.

@nsoranzo
Copy link
Member

nsoranzo commented May 2, 2017

I think we already removed this in dev.

@mvdbeek Not in config/galaxy.ini.sample .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants