Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors in upload are not shown as erroneous dataset #5214

Closed
bernt-matthias opened this issue Dec 14, 2017 · 3 comments
Closed

errors in upload are not shown as erroneous dataset #5214

bernt-matthias opened this issue Dec 14, 2017 · 3 comments
Labels
kind/bug

Comments

@bernt-matthias
Copy link
Contributor

Errors happening during download don't mark the created data set as error.

screenshot from 2017-12-14 13-19-40
@mvdbeek
Copy link
Member

mvdbeek commented Dec 14, 2017

That's because the upload tool sets error using the stderr, but upload.py redirects stderr into galaxy.json, which is read after determining whether a job should fail based on its profile. I'm working on a fix.

@bernt-matthias
Copy link
Contributor Author

Wonderful. Thanks

mvdbeek added a commit to mvdbeek/galaxy that referenced this issue Dec 14, 2017
@mvdbeek
Read in stderr form galaxy.json
135ef09 
before checking whether stderr and exit code combination should result in a
failed job. This should fix galaxyproject#5214.
@mvdbeek mvdbeek mentioned this issue Dec 14, 2017
Merged
@mvdbeek
Copy link
Member

mvdbeek commented Dec 14, 2017

Thanks for reporting. That's a bug we really should have noticed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvdbeek @bernt-matthias