New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actions "for all selected" seem broken #5354
Comments
@bernt-matthias Thanks for the report, I'll take a look. |
I thought I reproduced this before, but I tried again today and am not having any luck this time. Selecting multiple datasets in the history, I'm able to use toggle hide, delete, unhide, and undelete and it's all working. I don't think anyone else has fixed this intentionally yet (I've been out a few days), but I could be wrong. Are you still seeing the same behavior? Ping @mvdbeek maybe, I think you said you saw it, too? |
Also tried. Works on dev and 17.09. Great :) |
What I've seen is that the delete operation fails on the first collection and stops all subsequent operations, that is definitely still an issue on dev and is not fixed by #5443 |
@mvdbeek Ok, that screenshot is a clue, thanks. Maybe this only happens when collections are in non-terminal states and/or jobs are running? I'll try a few more things. |
interesting, a simple collection in a new history has no problems, I'll try to narrow this down some more |
@mvdbeek Well, the traceback you're seeing there is related to the collection job state tracking. My guess is there's a sync event firing after the model deletion (due to the job state changes, maybe?), causing the failure here. This patch could fix it - https://gist.github.com/2786abaa792479fdf79345bdb598d682 jobStateSummariesCollection being undefined is guarded against similarly elsewhere. If you can reproduce it and this works for you, let me know and I'll PR it. |
@dannon fantastic, that works like a charm, thanks so much! |
@mvdbeek Thanks for testing it, I'll open a PR. |
Fixed in #5444 |
On the dev branch it seems that actions for multiple selected data sets are only executed for one of the selected data sets. This happened for delete and unhide.
Building dataset lists is working.
The text was updated successfully, but these errors were encountered: