Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions "for all selected" seem broken #5354

Closed
bernt-matthias opened this issue Jan 20, 2018 · 10 comments
Closed

Actions "for all selected" seem broken #5354

bernt-matthias opened this issue Jan 20, 2018 · 10 comments
Assignees
Milestone

Comments

@bernt-matthias
Copy link
Contributor

bernt-matthias commented Jan 20, 2018

On the dev branch it seems that actions for multiple selected data sets are only executed for one of the selected data sets. This happened for delete and unhide.

Building dataset lists is working.

@dannon
Copy link
Member

dannon commented Jan 20, 2018

@bernt-matthias Thanks for the report, I'll take a look.

@dannon dannon self-assigned this Jan 20, 2018
@bgruening bgruening added this to the 18.01 milestone Jan 20, 2018
@martenson martenson modified the milestones: 18.01, 18.05 Jan 25, 2018
@dannon dannon modified the milestones: 18.05, 18.01 Feb 1, 2018
@dannon
Copy link
Member

dannon commented Feb 2, 2018

I thought I reproduced this before, but I tried again today and am not having any luck this time. Selecting multiple datasets in the history, I'm able to use toggle hide, delete, unhide, and undelete and it's all working. I don't think anyone else has fixed this intentionally yet (I've been out a few days), but I could be wrong. Are you still seeing the same behavior?

Ping @mvdbeek maybe, I think you said you saw it, too?

@bernt-matthias
Copy link
Contributor Author

Also tried. Works on dev and 17.09. Great :)

@mvdbeek
Copy link
Member

mvdbeek commented Feb 2, 2018

What I've seen is that the delete operation fails on the first collection and stops all subsequent operations, that is definitely still an issue on dev and is not fixed by #5443
(I did rebuild the client)
screen shot 2018-02-02 at 10 25 53

@dannon
Copy link
Member

dannon commented Feb 2, 2018

@mvdbeek Ok, that screenshot is a clue, thanks. Maybe this only happens when collections are in non-terminal states and/or jobs are running? I'll try a few more things.

@mvdbeek
Copy link
Member

mvdbeek commented Feb 2, 2018

interesting, a simple collection in a new history has no problems, I'll try to narrow this down some more

@dannon
Copy link
Member

dannon commented Feb 2, 2018

@mvdbeek Well, the traceback you're seeing there is related to the collection job state tracking. My guess is there's a sync event firing after the model deletion (due to the job state changes, maybe?), causing the failure here. This patch could fix it - https://gist.github.com/2786abaa792479fdf79345bdb598d682

jobStateSummariesCollection being undefined is guarded against similarly elsewhere. If you can reproduce it and this works for you, let me know and I'll PR it.

@mvdbeek
Copy link
Member

mvdbeek commented Feb 2, 2018

@dannon fantastic, that works like a charm, thanks so much!

@dannon
Copy link
Member

dannon commented Feb 2, 2018

@mvdbeek Thanks for testing it, I'll open a PR.

@jmchilton
Copy link
Member

Fixed in #5444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants