New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.01] Ensure jobStateSummariesCollection exists; #5444

Merged
merged 1 commit into from Feb 2, 2018

Conversation

Projects
None yet
4 participants
@dannon
Member

dannon commented Feb 2, 2018

events can fire during deletion actions causing this action to fail and halt execution; this just skips it and the objects should get cleaned up during the normal course of things.

fixes #5354

(I did some cleanup in the file while looking for this, but will open a separate PR against dev including that)

Ensure jobStateSummariesCollection exists; events can fire during del…
…etion actions causing this event to fail
@jmchilton

This comment has been minimized.

Member

jmchilton commented Feb 2, 2018

Crap - sorry @dannon - thanks for the fix!

@mvdbeek mvdbeek merged commit 6c013d0 into galaxyproject:release_18.01 Feb 2, 2018

6 checks passed

api test Build finished. 342 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 171 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 4 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@galaxybot

This comment has been minimized.

galaxybot commented Feb 2, 2018

This PR was merged without a milestone attached.

@dannon dannon added this to the 18.01 milestone Feb 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment