Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pasting URL into upload dialog does not work #762

Closed
bgruening opened this issue Sep 21, 2015 · 6 comments · Fixed by #778
Closed

pasting URL into upload dialog does not work #762

bgruening opened this issue Sep 21, 2015 · 6 comments · Fixed by #778
Assignees
@guerler
Labels
area/UI-UX kind/bug

Comments

@bgruening
Copy link
Member

If you paste a URL or some other content into the upload dialog with your mouse (right click) the filesize label is not triggered to be updated and without a size the upload will be aborted.
dannon added a commit to dannon/galaxy that referenced this issue Sep 23, 2015
@dannon
Fix upload event binding to be input and change instead of just relyi…
292642e 
…ng on keyup. This fixes galaxyproject#762
@dannon dannon mentioned this issue Sep 23, 2015
Merged
dannon added a commit to dannon/galaxy that referenced this issue Sep 23, 2015
@dannon
Fix upload event binding to be input and change instead of just relyi…
7665d58 
…ng on keyup. This fixes galaxyproject#762
@dannon dannon mentioned this issue Sep 23, 2015
Closed
@dannon
Copy link
Member

dannon commented Sep 23, 2015

Should be resolved with #778

@bgruening
Copy link
Member Author

Thanks @dannon for the quick fix! Can we move this over to stable?

@dannon
Copy link
Member

dannon commented Sep 23, 2015

@bgruening If that's a +1 (yielding two +1s), then I'll cherry-pick it over and merge forward.

@martenson
Copy link
Member

I am +1 on this being in 15.07 but I do not think the votes are transitive in this direction.

@dannon
Copy link
Member

dannon commented Sep 23, 2015

We have in the past, but I'll just make a separate PR, that's fine.

@dannon
Copy link
Member

dannon commented Sep 23, 2015

Was clunky to apply anyway, due to conflicts and recent changes. I reopened a new PR against 15.07.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guerler guerler

Labels
area/UI-UX kind/bug
Projects
None yet
Milestone
No milestone
4 participants
@dannon @bgruening @martenson @guerler