[20.09] Fix masthead items disappearing on small screens #10641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it reserves some space to show active scratchbooks. This removes the weird space in between the scratchbook and the masthead extensions.
mvdbeek
changed the title
mvdbeek
force-pushed
the
fix_masthead_disappearing
branch
from
33fc316
to
699b5c8
Compare
dannon
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is to not set toggleable on
<b-navbar>. I also played with with adding a<b-navbar-toggle/>to display a button on the right for small screens, but I didn't manage to get something that looks nice, though it's probably not hard for someone that knows css.To get a little bit more space in the navbar I'm setting the (non-functional) chat server item to
display: noneand I'm moving the scratchbook to the rightmost position (since it reserves some space just on the right to display active scratchbooks).With this in place I see the full navbar on my phone.
Fixes #9844.