[15.10] Fix a bug in IEs when proxying the proxy #1076
Conversation
conditional. Also, fix a bug when using a proxy for the node proxy and cookie_path is /
|
@natefoo I was able to build Adding a little bit of documentation: |
|
@bgruening Working on Test w/ BTW, was the problem with Docker Hub really the |
|
There was two things one bug in Docker hub that was fixed yesterday and the |
[15.10] Fix a bug in IEs when proxying the proxy
|
|
||
| if hda.datatype.__class__.__name__ != "Ipynb": | ||
| with open( empty_nb_path, 'w+' ) as handle: | ||
| handle.write( empty_nb ) |
There was a problem hiding this comment.
Glad to see this removed! Good to have it part of the image. :)
There was a problem hiding this comment.
Oh, it isn't part of the image yet. @bgruening let's add a default notebook to the image?
There was a problem hiding this comment.
Strike that, I was looking at the master branch. We should probably update master eventually? Also why 15.10.1 instead of just updating 15.10?
There was a problem hiding this comment.
Also I know realise we're in november, and fully understand why you did 15.10.1 :) thanks for doing the right thing @bgruening
There was a problem hiding this comment.
For people that are already using 15.10, just a way to prevent any harm.
Master is updated as soon as 15.10 is out.
Also, make use of the /import volume conditional.