Fix 500 error when attempting to update installed repository. #1082
Conversation
| @@ -335,6 +335,17 @@ def shrink_string_by_size( value, size, join_by="..", left_larger=True, beginnin | |||
| return value | |||
|
|
|||
|
|
|||
| def parse_query_string( query_string ): | |||
There was a problem hiding this comment.
Should this function be able to deal with malicious query_strings ? E.g.: 'foo=3&bar=4&', 'foo&pluto=4'
There was a problem hiding this comment.
I don't think it will be necessary, but there's absolutely no harm in preventing malice.
There was a problem hiding this comment.
Brilliant, thanks! I think that now that you've added if '=' not in argument, you can remove:
if '=' not in query_string:
return {}
There was a problem hiding this comment.
@carlfeberhard reminded me that urlparse.parse_qs exists.
|
is there an example of repo that has this problem? @bgruening @davebx |
|
@martenson I've been able to reliably cause the error locally, but not when installing or updating from TTS. |
|
This PR solves the issue for me, thanks @davebx ! |
Fix 500 error when attempting to update installed repository.
|
@davebx @martenson this is a bugfix can we get it into 15.10? |
|
@bgruening I am working on that already, stay tuned! :) |
|
Thanks! |
No description provided.