Put new toolshed tools in existing tool panel sections if the ID matches #10984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will place a newly installed toolshed tool, if the target section exists, in that previously defined section in the shed_tool_conf file. Previously the section would simply be placed at the very end, whether or not that section already existed in the XML.
bgruening
reviewed
Dec 27, 2020
lib/galaxy/tool_shed/galaxy_install/tools/tool_panel_manager.py
Outdated
Show resolved
Hide resolved
|
This currently leaves an empty section behind in the shed_tool_conf.xml file, Do you have a moment to look at this @davebx ? |
mvdbeek
reviewed
Jan 12, 2021
lib/galaxy/tool_shed/galaxy_install/tools/tool_panel_manager.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
mvdbeek
approved these changes
Jan 12, 2021
mvdbeek
reviewed
Jan 13, 2021
lib/galaxy/tool_shed/galaxy_install/tools/tool_panel_manager.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will place a newly installed toolshed tool, if the target section exists, in that previously defined section in the shed_tool_conf file. Previously the section would simply be placed at the very end of the shed tool config, whether or not that section already existed in the XML.