Type checking fixes for galaxy-data (datatypes and models). #11007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
added
kind/bug
kind/enhancement
kind/refactoring
jmchilton
changed the title
jmchilton
commented
Dec 28, 2020
| @@ -1,6 +1,10 @@ | |||
| # TODO: revisit ignoring type and write some tests for this, the multi-inheritance in this | |||
| # this file is challenging, it should be broken into true mixins. | |||
| # type: ignore | |||
jmchilton
force-pushed
the
mypy_galaxy_data
branch
from
a328de1
to
a7b6f08
Compare
jmchilton
changed the title
bgruening
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.