Bugfix/8488/rule builder fails for one bad url #11276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gfix/8488/rule-builder-fails-for-one-bad-url
…gfix/8488/rule-builder-fails-for-one-bad-url
jmchilton
reviewed
Feb 2, 2021
jmchilton
reviewed
Feb 4, 2021
jmchilton
reviewed
Feb 4, 2021
…gfix/8488/rule-builder-fails-for-one-bad-url
jmchilton
reviewed
Feb 9, 2021
jmchilton
reviewed
Feb 9, 2021
mvdbeek
reviewed
Feb 9, 2021
jmchilton
reviewed
Mar 2, 2021
jmchilton
reviewed
Mar 2, 2021
|
We discussed this in person - I was hoping you'd test uploading two sets of URLs with different options and make sure the options work and are distinctly handled in both cases. Thanks! |
|
I'll admit the code confuses me but it seems to work. I'm going to merge this - thanks so much @assuntad23! |
|
This PR was merged without a "kind/" label, please correct. |
mvdbeek
added a commit
to mvdbeek/galaxy
that referenced
this pull request
Apr 20, 2021
This broke in galaxyproject#11276, which moved all URL style uploads to fetch_data, but didn't build the right payload for ftp / file_source uploads.
6 tasks
mvdbeek
added a commit
to mvdbeek/galaxy
that referenced
this pull request
May 18, 2021
6 tasks
mvdbeek
added a commit
to mvdbeek/galaxy
that referenced
this pull request
May 18, 2021
mvdbeek
added a commit
to mvdbeek/galaxy
that referenced
this pull request
May 18, 2021
mvdbeek
added a commit
to mvdbeek/galaxy
that referenced
this pull request
May 18, 2021
almahmoud
pushed a commit
to almahmoud/galaxy
that referenced
this pull request
May 19, 2021
This was referenced May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLs uploaded now use Data Fetch.
Fix for #8488
To test:
Try to upload these URLs using the Default or the Collection upload modal:
https://zenodo.org/api/files/55133323-b15b-45b4-98c9-dda00288b53f/nurse.bw
https://zenodo.org/api/files/55133323-b15b-45b4-98c9-dda00288b53f/nurse_Amel4.5_accepted_hits.bam
On main/usegalaxy, they will both fail, because one URL is bad. On this branch, only the bad branch will fail.
On Composite, the job still uses the upload1 tool, because if a URL fails, the dataset should be in an error state.