Add ready-to-go gitpod config #11509
Conversation
|
I can take a more in-depth look later, but I have to remind myself why we swapped to the more strict (but have to hope correct) standard lib cookie handling -- this has come up before. Pretty cool though! |
|
Thanks @dannon!
While that would be super cool the fuse module is not available (even of you opt in to the beta, which gives you access to docker and superuser). Something to check with their support, maybe this could be enabled. |
This commit implements a fully-automated development setup using Gitpod.io, an online IDE for GitLab, GitHub, and Bitbucket that enables Dev-Environments-As-Code. This makes it easy for anyone to get a ready-to-code workspace for any branch, issue or pull request almost instantly with a single click. Includes vscode gitpod config for debugging and testing.
Noticed this attempting to run Galaxy in gitpod. The cookies coming in on gitpod look like this
```
'_ga=xyz;_gid=abcdef;gitpod-user=loggedIn;theme={%22id%22:%22dark%22%2C%22mode%22:%22dark%22%2C%22colors%22:{%22brand%22:%22#0e639c%22%2C%22brand2%22:%22#1177bb%22%2C%22background1%22:%22#1e1e1e%22%2C%22background2%22:%22#252526%22%2C%22background3%22:%22#1e1e1e%22%2C%22paperShadow%22:%22#000000%22%2C%22fontColor1%22:%22#d4d4d4%22%2C%22fontColor2%22:%22#cccccc%22%2C%22fontColor3%22:%22rgba(255%2C%20255%2C%20255%2C%200.25)%22%2C%22disabled%22:%22rgba(14%2C%2099%2C%20156%2C%200.5)%22}};galaxysession=c6ca0ddb55be603abffc374394700ced40665f459edc4056f96aa8b94aeae1550e17382a9bb2794f'
```
which doesn't fit the parsing we do. The standard webob.cookies parser has no problem with such a cookie.
mvdbeek
force-pushed
the
mvdbeek/gitpod-setup
branch
from
6c084d1
to
6dc56bb
Compare
|
fwiw the parse_cookies function is here: https://github.com/Pylons/webob/blob/master/src/webob/cookies.py#L201 and it does some validation using the regexes here: https://github.com/Pylons/webob/blob/master/src/webob/cookies.py#L336-L344 |
|
@mvdbeek Yeah, the cookie handling looks good there. Test failure is unrelated. |
Once the workspace is pre-built it takes about 30-60 seconds to start the Gitpod environment, which gives you the option to start Galaxy within vscode in the browser, or run the tests, or do whatever you want in the terminal. We're also automatically starting
make client-watch, so you can start changing the client and see the results in the browser.If you start Galaxy in the debug configuration you'll be asked if you want to open the port, and then you can interact with a live Galaxy instance.
This is great for working on multiple branches, you don't need to switch branches, install dependencies and build the client ... just switch to a new tab in your browser.
Here's the Galaxy interface served in gitpod
And here are the tests:
To get this to work I had to fix the cookie parsing in 61cefb3
We could also setup cvmfs, and this might also be really cool for IUC and IWC.