Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.01] Single User Mode - Disable irrelevant and broken options #11669

Merged
merged 11 commits into from
Mar 22, 2021

Conversation

dannon
Copy link
Member

@dannon dannon commented Mar 18, 2021

What did you do?

  • Assorted enhancements to generally hide interface options that are either broken or pointless in single user mode.

Why did you make this change?

How to test the changes?

  • Instructions for manual testing are as follows:
    1. set single_user in galaxy.yml; observe UI and note 'sharing' and other options are gone. Also, please look for things I missed that still don't make sense.

For UI Components

  • I've included a screenshot of the changes

image

@dannon dannon marked this pull request as ready for review March 18, 2021 19:40
@github-actions github-actions bot added this to the 21.05 milestone Mar 18, 2021
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There's still a lot of contextual menus pointing to shared links (e.g the workflow/history share menus), but this is a step up and we should probably set this in planemo serve, which is always going to be run in single user mode.

@jmchilton
Copy link
Member

we should probably set this in planemo serve

I think we're at least trying to do that. That is why we added the option I think.

planemo/options.py
680:def single_user_mode_option():
682:        "galaxy_single_user",
683:        "--galaxy_single_user/--no_galaxy_single_user",
687:              "is just one user and this user is automatically logged it. Use --no_galaxy_single_user "
1142:        single_user_mode_option(),

planemo/galaxy/config.py
569:    if kwds.get("galaxy_single_user", True):
570:        properties['single_user'] = user_email

@mvdbeek
Copy link
Member

mvdbeek commented Mar 22, 2021

Hadn't used serve in a while ... that's cool then, thanks @jmchilton!

@mvdbeek mvdbeek merged commit 0f8aca6 into galaxyproject:release_21.01 Mar 22, 2021
@dannon
Copy link
Member Author

dannon commented Mar 22, 2021

Thanks @mvdbeek! Yeah, I was just trying to get a first pass in on most of the toplevel views -- I'm sure we'll keep finding stuff and can follow up on more later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants