Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor library folder contents api #11686

Merged
merged 7 commits into from
Mar 23, 2021
Merged

Refactor library folder contents api #11686

merged 7 commits into from
Mar 23, 2021

Commits on Mar 22, 2021

  1. Small refactoring in folder_contents API controller 

    - Remove unused UsesLibraryMixin
- Extract some common constants
- Use f-strings
- Simplify some expressions
- Remove redundant ldda_message sanitization
- Rename some private functions for consistency
    @davelopez
    davelopez committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    98dbd26 View commit details
    Browse the repository at this point in the history

  2. Add folder_contents API test for include deleted permissions

    @davelopez
    davelopez committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    b21bafb View commit details
    Browse the repository at this point in the history

  3. Simplify load folder contents access logic

    @davelopez
    davelopez committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    f699f4e View commit details
    Browse the repository at this point in the history

  4. Move legacy controller logic to FolderContentsAPIView class

    @davelopez
    davelopez committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    d1e86be View commit details
    Browse the repository at this point in the history

  5. Drop actions not implemented

    @davelopez
    davelopez committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    2f21662 View commit details
    Browse the repository at this point in the history

  6. Improve some docstrings

    @davelopez
    davelopez committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    d60c8d8 View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary user setup from tests

    @davelopez
    davelopez committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    38f64bd View commit details
    Browse the repository at this point in the history