Refactor library folder contents api #11686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davelopez
added
area/libraries
davelopez
force-pushed
the
refactor_library_folder_contents_api
branch
from
038954b
to
509dc23
Compare
jmchilton
reviewed
Mar 22, 2021
jmchilton
reviewed
Mar 22, 2021
jmchilton
approved these changes
Mar 22, 2021
- Remove unused UsesLibraryMixin - Extract some common constants - Use f-strings - Simplify some expressions - Remove redundant ldda_message sanitization - Rename some private functions for consistency
davelopez
force-pushed
the
refactor_library_folder_contents_api
branch
from
509dc23
to
38f64bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you do?
folder_contentscontroller logic to simplify it a bit.FolderContentsAPIViewclass that will be shared with the future FastAPI controller.Additional details
This time, instead of creating a corresponding
FolderContentsManagerinlib/galaxy/managers/folder_contents.py, I have tried a new approach creating the analogous FolderContentsAPIView class beside the legacy controller to keep the UsesLibraryMixinItems until it can be removed. I didn't want to remove it yet since is used across various places and will require much more changes.Anyway, I'm still struggling a bit with how to layout managers, controllers, views, etc. so any advice or recommendations are really appreciated :)
Why did you make this change?
This is part of the efforts to migrate the existing API to FastAPI in relatively small steps.
How to test the changes?