Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update localisation options to include Español #11791

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

hexylena
Copy link
Member

@hexylena hexylena commented Apr 6, 2021

What did you do?

  • the l10n options in user preferences sample file were missing Spanish, despite it being in ./client/src/nls/
  • Updated the user preference selectors to use the localised versions of language names. (though I don't think anyone would be able to find this menu if they didn't speak enough english to get there.)

Open questions: can we remove the locale directory in the root, right? Not touched since 2011/references makos?

Why did you make this change?

@nomadscientist was asking about support for Spanish in the GTN and on EU, I noticed the 'es' directory that wasn't included, and she relates that one of their departments regularly has a group that can work on small en→es translation tasks.

How to test the changes?

(select the most appropriate option; if the latter, provide steps for testing below)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. copy the user-preferences sample to a non-sample version
    2. start galaxy
    3. select Español
    4. ¡Éxito!

License

For UI Components

  • I've included a screenshot of the changes

¿Donde está la biblioteca? Aqui:

image

l10n:

image

@github-actions github-actions bot added this to the 21.05 milestone Apr 6, 2021
@hexylena hexylena changed the title Update localisation options Update localisation options to include Español Apr 6, 2021
@jmchilton jmchilton merged commit 3c1f887 into galaxyproject:dev Apr 6, 2021
@jmchilton
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants