Make datatype h5_model for machine leaning models #11825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Peek the model |
bgruening
reviewed
Apr 13, 2021
jmchilton
reviewed
Apr 13, 2021
qiagu
changed the title
|
Dynamic options for the hyperparameters are wanted. |
qiagu
changed the title
mvdbeek
reviewed
May 3, 2021
lib/galaxy/tool_util/xsd/galaxy.xsd
Outdated
| @@ -3519,6 +3519,11 @@ used to generate dynamic options. | |||
| <xs:documentation xml:lang="en">Documentation for startswith</xs:documentation> | |||
| </xs:annotation> | |||
| </xs:attribute> | |||
| <xs:attribute name="meta_file_key" type="xs:string"> | |||
There was a problem hiding this comment.
Can you separate out the meta_file_key changes, I assume that's handled in #11832 ?
There was a problem hiding this comment.
It's right. Once the meta_file_key implemented in #11832 gets merged into Galaxy, dynamic options can be made using the metadata FileParameter, hyper_params specifically, of H5MLM.
|
@mvdbeek Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you do?
Why did you make this change?
(Cite Issue number OR provide rationalization of changes if no issue exists)
(If fixing a bug, please add any relevant error or traceback)
How to test the changes?
(select the most appropriate option; if the latter, provide steps for testing below)
License
For UI Components