-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toml datatype #11909
Add toml datatype #11909
Conversation
Add toml datatype. MetaMorpheus proteomics application uses toml format for parameter configuration.
Hi @jj-umn.. Are you planning to wrap metamorpheus? I also looked into this because a colleague was interested. How do you plan to use toml files? In my preliminary thoughts about a wrapper I imagined to realize the toml inputs as config files. |
@bernt-matthias I've started on MetaMorpheus. I know the PeptideShaker developers are also interested in including MetaMorpheus. As soon as I get the basics working, I'll create a pull request that we can work from. |
@jj-umn this is great. I'm just wondering if a toml data type is needed. Do you plan to use this as input / output of the tool? What would be the advantage of this? |
@bernt-matthias The calibration task outputs toml files (one for each mzml) that should be used in the GPTMD and Search tasks. In addition, I was planning to allow a user to input a toml file for configuration. I still thinking about whether to make a single metamorpheus.xml tool that could perform multiple "Tasks", or if it is better to have separate task tools: metamorpheus_calibration.xml, metamorpheus_g_ptm_d.xml, metamorpheus_search.xml. I currently putting just about everything in a macros.xml so that it could be done either way. Let me know if you have any thoughts about that. You can email me at jj@umn.edu |
I think multiple tools might be more intuitive for users. If you go for a single tool than this might look pretty awkward in workflows, since all steps would have the same id (not sure if this can be changed in the workflow editor). If you got something then put open a PR on galaxyp and I'm happy to comment / review. |
Add toml datatype. MetaMorpheus proteomics application uses toml format for parameter configuration.
What did you do?
Why did you make this change?
The GalaxyP group plans to add Galaxy tools for the MetaMorpheus proteomics application from UW Madison.
https://github.com/smith-chem-wisc/MetaMorpheus
MetaMorpheus proteomics application uses toml format for parameter configuration.
I think it is sufficient to have this as just a subclass of Text.
I put with "Proteomics" datatypes, however, toml is a configuration format that could be used in other contexts.
How to test the changes?
(select the most appropriate option; if the latter, provide steps for testing below)
License
For UI Components