Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21.05] restrict invalid input in library pagination #11996

Merged
merged 3 commits into from
May 20, 2021
Merged

[21.05] restrict invalid input in library pagination #11996

merged 3 commits into from
May 20, 2021

Conversation

OlegZharkov
Copy link
Contributor

@OlegZharkov OlegZharkov commented May 18, 2021 •
edited
Loading

What did you do?

restricted negative input in pagination field

Why did you make this change?

fixes #11993

How to test the changes?

  1. open folder, try to enter a negative value

License

@github-actions github-actions bot added this to the 21.09 milestone May 18, 2021
@OlegZharkov OlegZharkov changed the base branch from dev to release_21.05 May 18, 2021 18:42
@OlegZharkov OlegZharkov changed the title restrict negative values in library pagination [21.05] restrict negative values in library pagination May 18, 2021
@OlegZharkov OlegZharkov modified the milestones: 21.09, 21.05 May 18, 2021
@OlegZharkov @mvdbeek
Update client/src/components/Libraries/LibrariesList.vue
7d31760 
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
@OlegZharkov OlegZharkov marked this pull request as draft May 19, 2021 14:34
@OlegZharkov OlegZharkov changed the title [21.05] restrict negative values in library pagination [21.05] restrict invalid input in library pagination May 19, 2021
@OlegZharkov OlegZharkov marked this pull request as ready for review May 19, 2021 14:42
@mvdbeek mvdbeek merged commit 8888ae3 into galaxyproject:release_21.05 May 20, 2021
@OlegZharkov
Copy link
Contributor Author

thanks @mvdbeek

@OlegZharkov OlegZharkov mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek left review comments

@davelopez davelopez davelopez left review comments

Assignees
No one assigned
Labels
area/UI-UX kind/bug paper-cut
Projects
None yet
Milestone
21.05
Development

Successfully merging this pull request may close these issues.

Libraries: number of items per page box accepts invalid input
3 participants
@OlegZharkov @mvdbeek @davelopez