Improved logging related tool test timeouts. #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are transient failures of maxseconds.xml's tool test on Jenkins that I can't reproduce locally, hopefully improved logging will help. https://jenkins.galaxyproject.org/job/docker-framework/1309/testReport/junit/functional.test_toolbox/TestForTool_maxseconds/test_tool_000000/
| if exceeded: | ||
| message = 'Tool test run exceeded walltime [total %s, max %s], terminating.' % (slept, walltime_exceeded) | ||
| log.info(message) | ||
| raise AssertionError(message) |
There was a problem hiding this comment.
I think the log.info() is redundant.
There was a problem hiding this comment.
The message only appears once in the test log - https://jenkins.galaxyproject.org/job/docker-framework/1322/consoleFull
There was a problem hiding this comment.
Ops, I thought this was the test, now I see it's a helper, sorry.
martenson
added a commit
that referenced
this pull request
Dec 5, 2015
Improved logging related tool test timeouts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are transient failures of maxseconds.xml's tool test on Jenkins that I can't reproduce locally, hopefully improved logging will help.
https://jenkins.galaxyproject.org/job/docker-framework/1309/testReport/junit/functional.test_toolbox/TestForTool_maxseconds/test_tool_000000/