[21.09] Don't change panel view after installing repositories, clean up provider #12677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t setting default if set-default is false
mvdbeek
added
kind/bug
kind/enhancement
kind/refactoring
dannon
approved these changes
Oct 8, 2021
jmchilton
reviewed
Oct 8, 2021
| @@ -2,7 +2,7 @@ | |||
| <ConfigProvider class="d-flex flex-column" v-slot="{ config }"> | |||
| <ToolPanelViewProvider | |||
| v-slot="{ currentPanel, currentPanelView }" | |||
| :site-default-panel-view="config.default_panel_view" | |||
| :panel-view="config.default_panel_view" | |||
There was a problem hiding this comment.
The admin side of this looks closer with this PR. I mean this kind of reads to me like this should override their selection with this. But again... this is better than it was so I'm an approve on this PR.
jmchilton
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename site-default-panel-view to panel-view, fetch from store without setting default if set-default is false
Minor follow-up to #12655
How to test the changes?
(Select all options that apply)
License