[21.09] Show error message when history id is invalid #12985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davelopez
reviewed
Nov 26, 2021
OlegZharkov
force-pushed
the
fixhistoryerror
branch
from
7f0804d
to
c64d1bc
Compare
OlegZharkov
changed the title
OlegZharkov
force-pushed
the
fixhistoryerror
branch
from
749c194
to
1caa2b9
Compare
mvdbeek
reviewed
Nov 29, 2021
dannon
approved these changes
Dec 7, 2021
|
This PR was merged without a "kind/" label, please correct. |
mvdbeek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error discovered by @wm75 and @bgruening
This PR shows an error on fetching history with an invalid id. As a nice bonus, I removed jquery from this component (not sure what was the purpose of putting it there)
How it's now:
https://usegalaxy.eu/histories/view?id=randomid
After this fix:
How to test the changes?
(Select all options that apply)
License