Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay iframe creation for news until clicked #13116

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

dannon
Copy link
Member

@dannon dannon commented Jan 4, 2022

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    1. Watch network tab on page reload, ensure announce isn't loading.
    2. Click news, observe traffic.

License

@mvdbeek
Copy link
Member

mvdbeek commented Jan 5, 2022

Brilliant. Thanks @dannon!

@mvdbeek mvdbeek merged commit b74f9bf into galaxyproject:dev Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants