[21.09] Catch exceptions when job.user is None

[rhpvorderman]

prevents the following error:

galaxy.web.framework.decorators ERROR 2022-01-17 14:52:09,619 [p:18,w:1,m:0] [uWSGIWorker1Core1] Uncaught exception in exposed API method:
Traceback (most recent call last):
File "lib/galaxy/web/framework/decorators.py", line 282, in decorator
rval = func(self, trans, *args, **kwargs)
File "lib/galaxy/webapps/galaxy/api/jobs.py", line 113, in index
j['user_email'] = job.user.email
AttributeError: 'NoneType' object has no attribute 'email'

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these contributions under Galaxy's current license.
• I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to galaxy-committers@lists.galaxyproject.org.

[mvdbeek]

Could you take the logic in https://github.com/mvdbeek/galaxy/blob/d53cd3964d3ba69988f962a1347a1ca534063156/lib/galaxy/jobs/__init__.py#L2154-L2159 and move it as a user_email property to the Job class in lib/galaxy/model/__init__.py and then replace all usage of job.user.email with job.user_email ?

[rhpvorderman]

Hi, sorry for not checking back in yesterday, I had a busy schedule. Thanks @mvdbeek for finishing all the work!

[mvdbeek]

Np, thanks for getting it started.