Replace custom tour ids in forms with regular DOM identifiers #13252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guerler
added
area/UI-UX
kind/refactoring
|
element-id seems redundant and generic as a prefix for a DOM ID. My preference would be |
guerler
force-pushed
the
remove_tour_id
branch
4 times, most recently
from
a60c858
to
2b89c96
Compare
|
@jmchilton I agree with you, it is redundant. I replaced it with |
guerler
changed the title
guerler
force-pushed
the
remove_tour_id
branch
2 times, most recently
from
52d1d92
to
a6d5bef
Compare
guerler
force-pushed
the
remove_tour_id
branch
from
8c196d3
to
3ad96df
Compare
|
We're going to try to get this one into 22.01 to minimize conflicts with any bugfixes that may need to propagate forward. |
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #13246. This PR removes the custom
tour_iddom attribute and uses the regularidattribute instead to query form input elements. It also removes the input id replacement of|. Although a special character newer conventions do allow its use as part of a dom id. A benefit of this PR is that input element identifiers for dom elements are now equivalent to actual parameter identifiers used by the api and elsewhere.How to test the changes?
License