Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version.json for exposing extra api information about docker container #13433

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

nuwang
Copy link
Member

@nuwang nuwang commented Feb 23, 2022

curl http://localhost:8080/api/version

{
  "version_major": "21.09",
  "version_minor": "1.dev0",
  "extra": {
    "git_commit": "e82b50d5121c5d7b649607d816ab5a4b87ad2193",
    "build_date": "unspecified",
    "image_tag": "unspecified"
  }
}

build_date and image_tag will be populated correctly in a CI built container.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Build docker container and run above curl command

License

@github-actions github-actions bot added this to the 22.05 milestone Feb 23, 2022
@mvdbeek
Copy link
Member

mvdbeek commented Feb 23, 2022

Do you want to target any of the older branches ? I guess 21.09 would make sense ?

@nuwang nuwang changed the base branch from dev to release_21.09 February 23, 2022 16:15
@nuwang
Copy link
Member Author

nuwang commented Feb 23, 2022

Changed base to 21.09.

@mvdbeek mvdbeek merged commit 42d5380 into galaxyproject:release_21.09 Feb 24, 2022
@mvdbeek mvdbeek modified the milestones: 22.05, 22.01 Feb 24, 2022
@nuwang nuwang deleted the add_docker_version_json branch February 24, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants