Run jest tests using node 16 in CI #13434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After #13435 is merged I will rebase and, hopefully, confirm that the Client Unit Testing CI workflow doesn't fail anymore. |
4 tasks
I think this was meant to be changed in galaxyproject#13282
davelopez
force-pushed
the
run_client_tests_using_node_16
branch
from
e8fcdc3
to
02e409b
Compare
jdavcs
approved these changes
Feb 24, 2022
dannon
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
The failing tests are unrelated -- this looks good to me. Thanks for the catch @davelopez
|
Thank you both for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was meant to be changed in #13282
If my assumption is correct this will make the tests in #13409 actually fail instead of just displaying a warning.
How to test the changes?
License