Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade syntax to Python 3.7 #13500

Merged
merged 1 commit into from Mar 14, 2022
Merged

Upgrade syntax to Python 3.7 #13500

merged 1 commit into from Mar 14, 2022

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Mar 8, 2022

using ack --type=python -f | grep -v '^tools/' | xargs pyupgrade --py37-plus

Also more refactoring of Python files in packages/ .

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

@bgruening
Copy link
Member

Cool, but I guess we should wait until @jmchilton work has landed?

@nsoranzo
Copy link
Member Author

nsoranzo commented Mar 8, 2022

Which one? This is very small compared to the black PR.

@jmchilton
Copy link
Member

I have reservations about this but my open PRs are a non-issue here, feel free to merge.

@jdavcs

This comment was marked as resolved.

using `ack --type=python -f | grep -v '^tools/' | xargs pyupgrade --py37-plus`

Also more refactoring of Python files in `packages/` .
@nsoranzo
Copy link
Member Author

nsoranzo commented Mar 14, 2022

Rebased, and I've converted (almost) all format strings to f-strings. Ready for a re-review.

@nsoranzo
Copy link
Member Author

Thanks for the reviews @bgruening @ic4f !

@nsoranzo nsoranzo merged commit a972d23 into galaxyproject:dev Mar 14, 2022
@nsoranzo nsoranzo deleted the pyupgrade branch March 14, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants