Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more bulk operations to Beta History #13877

Merged
merged 16 commits into from Jun 8, 2022
Merged

Add more bulk operations to Beta History #13877

merged 16 commits into from Jun 8, 2022

Conversation

davelopez
Copy link
Contributor

@davelopez davelopez commented May 6, 2022 •
edited

Fixes #13828

New operations supported by api/histories/{history_id}/contents/bulk in the API:

TODO

  • Add API tests
  • Add operations to the client

How to test the changes?

  • I've included appropriate automated tests.
  • Instructions for manual testing are as follows:

    • Add / remove tags in bulk

      add-remove-tags

    • Change dbkey in bulk

      change_dbkey

License

@davelopez davelopez changed the title Add more bulk operations Beta History: add more bulk operations May 6, 2022
@davelopez davelopez force-pushed the add_more_bulk_operations branch 2 times, most recently from 4b00a16 to fbfe399 Compare May 10, 2022 13:29
@mvdbeek mvdbeek added this to the 22.05 milestone May 25, 2022
@mvdbeek mvdbeek self-assigned this May 25, 2022
@davelopez davelopez marked this pull request as ready for review May 25, 2022 20:57
@davelopez
Copy link
Contributor Author

If anyone has a better idea to replace f846ce6, probably with CSS magic, to avoid the dropdown being clipped it would be very welcome :)

@davelopez davelopez marked this pull request as draft May 26, 2022 09:25
@davelopez
Copy link
Contributor Author

davelopez commented May 26, 2022 •
edited

I think this is ready for review. I have included the UI changes to support the change_datatype operation but it is temporarily disabled in the UI and API in 2136d8a.

@mvdbeek, once #13655 is ready, please feel free to make the necessary changes to trigger the metadata regeneration in this PR or in a follow-up as you see fit and then revert 2136d8a. Or we can push it to the next release, whatever is you think is best :)

Thank you so much!

@davelopez davelopez marked this pull request as ready for review May 26, 2022 10:26
@davelopez davelopez mentioned this pull request May 26, 2022
Closed
@dannon
Copy link
Member

dannon commented Jun 7, 2022

@davelopez With #13655 in now, do you want us to update this here or in a subsequent PR?

@davelopez
Copy link
Contributor Author

do you want us to update this here or in a subsequent PR?

I don't have a strong preference :)

I will rebase this one now. And if we consider the rest of the operations are OK, maybe we can merge this one and enable the change datatype along with the metadata regeneration bits in a subsequent PR.

@dannon
Copy link
Member

dannon commented Jun 7, 2022

@davelopez Sounds good to me!

davelopez and others added 10 commits June 7, 2022 16:58
@davelopez
Add UI for setting tags in bulk
580aad0
@davelopez
Add UI for removing tags in bulk
133f3c3
@davelopez
Reset to default unknown ? genome on open modal
55144c3
@davelopez
Disable modal OK button until tags are input
8acf905
@davelopez
Style hack to minimize dropdown clipping
15aa8b1 
The modal dialog is too short and most of the dropdown selector gets clipped otherwise.

Better ideas of how to fix it are very welcome.
@davelopez
Display also general error
9d14f12 
After failed bulk operation
@davelopez
Add dropdown dividers to contents operations menu
dd1cc61
@davelopez
Add UI for setting datatype in bulk
433939b
@davelopez
Temporarily disable change_datatype bulk operation
45ef83b 
Until metadata can be regenerated in Celery
@davelopez @mvdbeek
Use correct term for dbkey
cc06f72 
Use `Database/Build` instead of `Genome`

Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
@davelopez davelopez mentioned this pull request Jun 8, 2022
Closed
@dannon dannon merged commit 19c3660 into galaxyproject:dev Jun 8, 2022
@davelopez davelopez deleted the add_more_bulk_operations branch June 8, 2022 10:03
@mvdbeek mvdbeek changed the title Beta History: add more bulk operations Add more bulk operations to Beta History Jun 28, 2022
@mvdbeek mvdbeek added the highlight Included in user-facing release notes at the top label Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening left review comments

@mvdbeek mvdbeek mvdbeek left review comments

Assignees

@mvdbeek mvdbeek

Labels
area/API area/UI-UX highlight Included in user-facing release notes at the top kind/feature
Projects
None yet
Milestone
22.05
Development

Successfully merging this pull request may close these issues.

Missing history batch operation
4 participants
@davelopez @dannon @bgruening @mvdbeek