Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy reexport error for testfixtures #14272

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Jul 6, 2022

Fix this mypy error for the galaxy-app package:

tests/app/jobs/dynamic_tool_destination/test_dynamic_tool_destination.py:5: error:
Module "testfixtures" does not explicitly export attribute "log_capture";
implicit reexport disabled  [attr-defined]
    from testfixtures import log_capture
    ^

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

Fix this mypy error for the galaxy-app package:

```
tests/app/jobs/dynamic_tool_destination/test_dynamic_tool_destination.py:5: error:
Module "testfixtures" does not explicitly export attribute "log_capture";
implicit reexport disabled  [attr-defined]
    from testfixtures import log_capture
    ^
```
@github-actions github-actions bot added this to the 22.09 milestone Jul 6, 2022
@jmchilton jmchilton merged commit cadd799 into galaxyproject:dev Jul 6, 2022
@nsoranzo nsoranzo deleted the mypy_testfixtures_fix branch July 6, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants